Repository navigation
ui(theme): use editorBackground and semantic palette tokens in SQL previews and document tree (#1644) - #1660
Merged
ZhuchkaTriplesix merged 1 commit intoOct 17, 2026
Conversation
…eviews and document tree (#1644)
ZhuchkaTriplesix
deleted the
issue/1644-editor-background-and-semantic-palette
branch
October 17, 2026 03:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes hardcoded background and foreground colors in SQL preview code blocks and maps MongoDB leaf node data types to active theme tokens (#1644).
Key Changes
lib/features/workspace/destructive_query_dialog.dart: Replaced hardcoded dark/light colors (0xFF141416/0xFFF4F4F6and0xFFE2E8F0/0xFF1E293B) withcontext.workbench.editorBackgroundandcs.foreground.lib/features/workspace/dml_preview_dialog.dart: Replaced hardcoded preview container and text colors withcontext.workbench.editorBackgroundandcs.foreground.lib/features/mongodb/mongo_document_tree_view.dart: Replaced raw literal hex values (0xFF22C55E,0xFF3B82F6,0xFFF97316,0xFF06B6D4) in_leafValueColorwith tokens fromcontext.semanticPalette(type1,type2,type3,type4,muted).Verification
flutter test test/features/workspace/destructive_query_dialog_test.dart test/features/workspace/dml_preview_dialog_test.dart test/features/mongodb/mongo_documents_view_modes_test.dart(23 tests passed)flutter analyze(0 issues found)Closes #1644