Skip to content

ui(theme): use editorBackground and semantic palette tokens in SQL previews and document tree (#1644) - #1660

Merged
ZhuchkaTriplesix merged 1 commit into
devfrom
issue/1644-editor-background-and-semantic-palette
Oct 17, 2026
Merged

ZhuchkaTriplesix merged 1 commit into
devfrom
issue/1644-editor-background-and-semantic-palette

Conversation

@ZhuchkaTriplesix

Copy link
Copy Markdown
Member

Summary

Fixes hardcoded background and foreground colors in SQL preview code blocks and maps MongoDB leaf node data types to active theme tokens (#1644).

Key Changes

  1. SQL Previews in Confirmation Dialogs:
    • lib/features/workspace/destructive_query_dialog.dart: Replaced hardcoded dark/light colors (0xFF141416 / 0xFFF4F4F6 and 0xFFE2E8F0 / 0xFF1E293B) with context.workbench.editorBackground and cs.foreground.
    • lib/features/workspace/dml_preview_dialog.dart: Replaced hardcoded preview container and text colors with context.workbench.editorBackground and cs.foreground.
  2. MongoDB Document Tree Semantic Palette:
    • lib/features/mongodb/mongo_document_tree_view.dart: Replaced raw literal hex values (0xFF22C55E, 0xFF3B82F6, 0xFFF97316, 0xFF06B6D4) in _leafValueColor with tokens from context.semanticPalette (type1, type2, type3, type4, muted).

Verification

  • flutter test test/features/workspace/destructive_query_dialog_test.dart test/features/workspace/dml_preview_dialog_test.dart test/features/mongodb/mongo_documents_view_modes_test.dart (23 tests passed)
  • flutter analyze (0 issues found)

Closes #1644

@github-actions github-actions Bot added enhancement New feature or request theme Theming, colors, VS Code themes frontend Theme parser epic label: frontend labels Oct 17, 2026
@ZhuchkaTriplesix
ZhuchkaTriplesix merged commit 241f3ae into dev Oct 17, 2026
12 of 13 checks passed
@github-actions github-actions Bot added this to the Theme system milestone Oct 17, 2026
@ZhuchkaTriplesix
ZhuchkaTriplesix deleted the issue/1644-editor-background-and-semantic-palette branch October 17, 2026 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request frontend Theme parser epic label: frontend theme Theming, colors, VS Code themes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant