Repository navigation
fix(sandbox): declarative engine JSONC, sql.format and sql.parse no longer regex over literals (#1567) - #1678
Merged
Merged
Conversation
…SQL outside literals, parses past leading comments (#1567)
Member
Author
🔍 Post-Merge Code Review & VerificationCrucial parser and formatter precision improvements:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1567.
_parseJsoncObjectusesstripJsonc(string-aware, trailing commas) instead of two regexes, so"https://example.com"survives.sql.formatlays out blanks and;only in code segments (SqlLexicalScanner) and uppercases throughformatSqlScript(fix(editor): Format SQL uppercases words inside string literals, quoted identifiers and comments #1566): literals, quoted identifiers and comments are kept as written. No per-call regex compilation.sql.parseskips leading comments (stripLeadingWhitespaceAndLineComments) and takes the first word with onefirstMatch.;inside literals/comments,uppercaseKeywords:false, parse after comments, JSONC with URL,/*in a string and a trailing comma.