Repository navigation
perf: cache the Redis folder key count; group aggregation parses numbers without copying - #1682
Merged
Merged
Conversation
…ut copying the cell
2 tasks
Member
Author
🔍 Post-Merge Code Review & VerificationLGTM! Excellent performance hardening across Redis folder trees and pivot calculations:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From a data-structure review (claims checked against the code).
late final); the engine hands out finished lists and does not change the tree afterwards.replaceAll(',', ''). It now uses the comma-aware parser of the selection stats (parseThousandsSeparated, documented as equal to the copy); anything it cannot read takes the old path, so results are unchanged. The@visibleForTestingon that parser is dropped since lib code uses it now.