Repository navigation
fix(updater): the Beta channel offers the highest version, not the first release by date (#1493) - #1691
Merged
Conversation
…rst release by date (#1493)
github-actions
Bot
added
bug
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1493. Part of the Beta channel epic #1499.
GitHubReleasesClient.fetchLatest(channel: dev)(Preferences: Beta / Early Access) returned the first non-draft entry of/releases, which the API orders by creation date. After0.5.0-beta.2, a hotfix0.4.20published frommainbecame the first entry, so a user on0.4.19was offered the hotfix and never the newer beta.pickNewestRelease(releases)returns the release with the highestUpdateVersion(compareTo: a stable release outranks its own beta,beta.10abovebeta.2). Drafts and tags that do not parse are skipped; an empty or all-unusable list is stillNo published releases found.releases/latest). Only the first page of the list is read, as before.Tests: the order cases from the issue (hotfix after beta, beta then stable,
beta.10vsbeta.2, leadingv, drafts and non-version tags, empty list) andfetchLatestthrough a mock HTTP client.