Repository navigation
fix(team): profile import skips and counts unreadable entries; more secret keys scrubbed (#1564) - #1693
Merged
Conversation
… of throwing; scrub pwd, private keys, access keys, credentials and signatures (#1564)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1564.
Import no longer throws on a bad field.
TeamProfileCodec.decodecast fields withas int?/as String?; a hand-edited or newer file with"port": "5432"raised aTypeError(not aTeamProfileFormatException) and the whole import failed.TeamProfileCodec.read(source)returns the rows and the number of skipped entries;decodeisread(...).rows, so existing callers keep working.portorhostdropped would point somewhere else.nullfields are fine.More secret keys are scrubbed from
driverOptionsand from the connection-string query, on export and again on import:pwd,private_key/privateKey,access_key/accessKey,credential(s),signature, besides the existingpass*,secret,token,api_key.authSourceandsslmodestay.Tests: each new key on export and on a hand-edited import; wrong-typed fields, entries that are not objects or lack type or name, and
nullfields;decodestill returns just the rows.