Skip to content

fix(team): profile import skips and counts unreadable entries; more secret keys scrubbed (#1564) - #1693

Merged
ZhuchkaTriplesix merged 1 commit into
devfrom
fix/team-profile-import-scrub
Oct 17, 2026
Merged

ZhuchkaTriplesix merged 1 commit into
devfrom
fix/team-profile-import-scrub

Conversation

@ZhuchkaTriplesix

Copy link
Copy Markdown
Member

Closes #1564.

Import no longer throws on a bad field. TeamProfileCodec.decode cast fields with as int? / as String?; a hand-edited or newer file with "port": "5432" raised a TypeError (not a TeamProfileFormatException) and the whole import failed.

  • New TeamProfileCodec.read(source) returns the rows and the number of skipped entries; decode is read(...).rows, so existing callers keep working.
  • An entry is skipped (and counted) when it is not an object, has no type or name, or has a field of the wrong type. It is skipped as a whole rather than imported without that field: a connection with its port or host dropped would point somewhere else. null fields are fine.
  • The import toast says how many entries were unreadable and skipped.

More secret keys are scrubbed from driverOptions and from the connection-string query, on export and again on import: pwd, private_key / privateKey, access_key / accessKey, credential(s), signature, besides the existing pass*, secret, token, api_key. authSource and sslmode stay.

Tests: each new key on export and on a hand-edited import; wrong-typed fields, entries that are not objects or lack type or name, and null fields; decode still returns just the rows.

… of throwing; scrub pwd, private keys, access keys, credentials and signatures (#1564)
@github-actions github-actions Bot added bug Something isn't working stability Theme parser epic label: stability core Core library logic and services P2 Medium priority / Parity & Refactoring labels Oct 17, 2026
@ZhuchkaTriplesix
ZhuchkaTriplesix merged commit b9a337c into dev Oct 17, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working core Core library logic and services P2 Medium priority / Parity & Refactoring stability Theme parser epic label: stability

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant