Repository navigation
fix(status-bar): a plain-count result no longer leaves 'Running query…' in the bar (#1556) - #1694
Merged
Merged
Conversation
…stead of keeping 'Running query…' (#1556)
github-actions
Bot
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1556.
GenericSqlWorkspacepassesmessage: _shellMessage(session.statusLine), which isnullfor a plain "N row(s)." line (the counts are already on the right of the bar).reportQueryResultthen didif (message != null) _statusMessage = message;and_messageIsBusy = false, so the "Running query…" set bybeginBusysurvived, was re-labelled as an ordinary message and no longer dropped byendBusy.reportQueryResultnow takes the message as given: the message describes this result, so anullclears the busy text and also any text left by an earlier run. It has one caller, so no other flow relied on the old keep-the-previous behaviour.Tests: the sequence from the issue (
beginBusy('Running query…')then a result without a message leavesstatusMessage == null, counts kept,endBusyafterwards changes nothing); a result without a message does not keep the text of an earlier run; a result with a message still shows it.