Repository navigation
motion: toasts animate out; the welcome tour slides in the direction of travel (#1645) - #1699
Merged
Merged
Conversation
…ur slides in the direction of travel (#1645)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1645.
Toasts (
app_toast.dart): a toast faded and slid in, but when its timer ran out or its close button was pressed it was removed at once, and the toasts above it jumped to their new places.SizeTransition), so the stack moves smoothly both when a toast arrives and when one leaves.Welcome tour (
welcome_tour_dialog.dart): every step slid in from the right, also after Back. The dialog now remembers whether the last move went forward (Next, a later dot) or back (Back, an earlier dot): the incoming step comes from that side and the outgoing one leaves on the other.Tests: a closing toast is still on screen and partly transparent mid-exit, then gone; with reduced motion it disappears on the next frame; the tour's incoming and outgoing slides move in opposite directions, mirrored for Back. Existing toast and tour tests are unchanged.