Repository navigation
ux(button): a cut-short QueryaButton label shows in full as a tooltip (#1689) - #1700
Merged
Merged
Conversation
…er, so buttons keep working in intrinsic layouts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1689.
QueryaButtondraws its label on one line with an ellipsis, and showed a tooltip only whentooltipwas set or the button was icon-only. A label cut short by a narrow toolbar could not be read at all.LayoutBuilder: buttons are laid out insideIntrinsicWidth/IntrinsicHeight(tab strip, stats views, shadcn popovers), where aLayoutBuilderthrows. The proxy passes intrinsic sizes through.tooltipstill wins, and those buttons skip the check. Icon-only buttons are unchanged.kQueryaTooltipWaitand is excluded from semantics: the button's semantic label is already the full text.Tests: a 90 px button with a long label gets a tooltip with the full text; a button that fits gets none; widening removes it; an explicit tooltip is kept and the label one is not added; a button inside
IntrinsicWidthlays out without an error.