Repository navigation
fix(stats): one polling controller for the overview screens (#1570) - #1713
Merged
Merged
Conversation
… request at a time, backoff on errors, a note when the numbers are stale (#1570)
github-actions
Bot
added
bug
…imer fails the invariants check (#1570)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1570
The five overview/stats screens (PostgreSQL, MySQL, Redis, MongoDB, extension drivers) each had a copy of
Timer.periodic+catch (_) {}.PollingController(core/motion/polling_controller.dart): the next tick is scheduled when the previous one finished, so at most one request is in flight and samples land in order. A failed tick doubles the wait (capped at 1 min), the first success returns to the normal interval.status(ValueListenable<PollStatus>) carries the last success time and the failure count.PollingStatemixin: starts/stops polling fromdidChangeDependencies(TickerMode) and from the places that change whether there is data to refresh (load finished/failed, interval picked), no longer frombuild.PollStaleOverlay: a small "Updates failed · showing HH:MM:SS" note in the corner while the latest poll failed; the dashboard keeps the last good numbers, but no longer looks live.ticker_gated_polling.dartand its test are removed (no users left).Tests: no overlap with a slow tick, backoff/cap/recovery, a stop during a running tick, interval change,
TickerModegating, dispose, the note.