Skip to content

ci(bench): erd_open_200 diagnoses itself; an aborted bench run fails the job (#1546) - #1714

Merged
ZhuchkaTriplesix merged 2 commits into
devfrom
ci/bench-erd-exit-code
Oct 18, 2026
Merged

ZhuchkaTriplesix merged 2 commits into
devfrom
ci/bench-erd-exit-code

Conversation

@ZhuchkaTriplesix

Copy link
Copy Markdown
Member

Refs #1546

The erd_open_200 scenario timed out waiting for a diagram of 200 tables and the bench still exited 0, so everything after it went unchecked.

  • The scenario now checks the 200-table script ran (session.error, status line printed as BENCH erd_ddl), waits for the Diagram tab first and then for the cards, and on a timeout prints BENCH erd_state (active tab, whether it is the diagram, number of erd_table_* cards). This tells the two causes in the issue apart (script did not create the tables vs. the diagram never opened).
  • A scenario error prints BENCH FAILED: ... and the app exits 1. flutter run reports 0 whatever the app does, so the app-bench job has a step that fails on that line; app_bench_report.py names the reason in the summary (tests added). The job stays continue-on-error.

The cause of the original timeout is not fixed here: the benchmark workflow on this PR runs the scenario and shows which of the two it is. The issue stays open until erd_open_200 prints numbers.

@github-actions github-actions Bot added bug Something isn't working performance Theme parser epic label: performance tests Theme parser epic P3 Low priority / Polish & Enhancements labels Oct 18, 2026
@github-actions github-actions Bot added this to the 0.5.0 milestone Oct 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working P3 Low priority / Polish & Enhancements performance Theme parser epic label: performance tests Theme parser epic

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant