Repository navigation
fix(macos): connections were not saved: secrets go to the login keychain - #1756
Closed
ZhuchkaTriplesix wants to merge 1 commit into
Closed
ZhuchkaTriplesix wants to merge 1 commit into
ZhuchkaTriplesix wants to merge 1 commit into
Conversation
…protection keychain needs an entitlement the signed build lacks
Member
Author
|
Closed: dev already has this fix (#1586, ConnectionSecretsStore.macOsOptions). This PR was also pushed with merge-conflict markers by mistake. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On macOS a new connection is not kept. `LocalDb.addConnection` inserts the row, writes the password to the secure store, and rolls the row back when that write throws.
`flutter_secure_storage` uses the data-protection keychain on macOS by default (`usesDataProtectionKeychain: true`). That needs the `keychain-access-groups` entitlement, which `ReleaseSigned.entitlements` (non-sandboxed Developer ID build) does not carry, so the write should fail with errSecMissingEntitlement (-34018) and the row is rolled back. This change switches macOS to the login keychain (`usesDataProtectionKeychain: false`).
Not verified on a Mac. The cause is inferred from the code and entitlements, not from an observed error. Please check on a Mac that a new connection with a password survives an app restart. If it still fails, the error now shows in the debug log (`PostgresConnection.connect` logging from #1755).
No existing secrets are affected: with the old setting nothing could have been written on the signed build.