Conversation
|
There was a problem hiding this comment.
Pull request overview
This PR migrates the build tool from tsup to tsdown for the @qwikdev/create-astro package, claiming a ~28% performance improvement (2.87s vs 4.00s). The migration removes the --env.NODE_ENV production flag since the only usage of NODE_ENV is in the runtime-evaluated isTest() function.
Changes:
- Replaced tsup with tsdown as the build tool
- Updated build scripts to use tsdown commands
- Migrated configuration from tsup to tsdown (import statement change only)
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| libs/create-qwikdev-astro/package.json | Updated devDependencies and build scripts to use tsdown instead of tsup |
| libs/create-qwikdev-astro/tsdown.config.ts | Changed import statement from tsup to tsdown (configuration remains identical) |
| pnpm-lock.yaml | Added tsdown v0.20.1 and its dependencies (including rolldown v1.0.0-rc.1), removed tsup and its dependencies |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
commit: |
|
Thanks for the PR 🙏 The migration from Given the scope of the changes, I’ll still test this version locally and may Thanks again for the contribution! |
|
I'm all for moving this to tsdown! For reference, I am currently working on moving the qwik optimizer / compiler to oxc from swc in Rust. I am also working on: Which uses a lot of the oxc toolchain in various parts on the typescript side. All libraries are Qwik libraries with the rolldown config. @siguici let me know if you need me to review when finished |
|
thanks! and nice design system project :) |
|
Agreed 👍 After local verification, I didn’t find any issues. I’m good to merge. |
|
Thank you! |
Migrate build tool from tsup to tsdown.
Benchmark: ~28% faster (2.87s vs 4.00s average)
Removed --env.NODE_ENV production flag as it's unnecessary - the only NODE_ENV usage is isTestMode() which should evaluate at runtime.