chore(deps): replace jsx-ast-utils with jsx-ast-utils-x#7938
chore(deps): replace jsx-ast-utils with jsx-ast-utils-x#7938andreww2012 wants to merge 2 commits intoQwikDev:mainfrom
Conversation
🦋 Changeset detectedLatest commit: ebcf7db The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
maiieul
left a comment
There was a problem hiding this comment.
Thanks for the PR. We will discuss this with the team first.
|
@andreww2012 Apart faster |
|
@maiieul I don't know, and I also haven't done any performance testing. I actually don't work with qwik codebase 😄 |
|
Ok. Thanks for sharing. I'm a bit concerned about the maintenance cost if it stop being maintained, but the other one doesn't seem to be updated a lot either. So I will merge. Relying on less dependencies is likely a good thing :) May I ask you to rebase? |
Head branch was pushed to by a user without write access
0f476f4 to
ebcf7db
Compare
What is it?
Description
This PR replaces a very heavy
jsx-ast-utilspackage with a much lighter alternativejsx-ast-utils-x, which has compatible API and zero dependencies.A very popular ESLint plugin,
eslint-plugin-sonarjs, has already performed this switch (see the original issue).After this change the dependency graph and installation size of
eslint-plugin-qwikpackage should reduce significantly.Checklist
pnpm change