fix(qwik-city): remove doubling of assetDir on postBuild#8152
fix(qwik-city): remove doubling of assetDir on postBuild#8152intellix wants to merge 2 commits intoQwikDev:mainfrom
Conversation
🦋 Changeset detectedLatest commit: e21c487 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
e6b92df to
9299762
Compare
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
commit: |
|
I am noticing one thing locally and that's sounds imported via ?url suffix aren't working correctly but I think that's a Vite thing, even on the latest. I'll test with/without this fix as well just to be sure. The mp3 is loaded relative to the component like so: On a local serve, it loads correctly. On preview/build, the file is sent to /q/assets/AbC-dEf123-click.mp3 but the code tries to load it without the /q/ prefix. |
|
The mp3 issue isn't fixed by removing my patch. I guess it's unrelated as the assetsDir in my PR is only used for generating the staticPaths. I'm not sure if it's a vite or qwik thing but I'll investigate in a separate reproduction |
9299762 to
193b0ed
Compare
wmertens
left a comment
There was a problem hiding this comment.
can you add a check to one or more of the /e2e tests that verifies that the staticpaths are correct?
Ideally, have the e2e tests build multiple times, with combinations of assetDir and base
What is it?
Description
Removed doubling of assetsDir during bundle close when delivering staticPaths list: #8151
All info in the linked issue but I'll repeat a little how this is broken.
Vite config:
Now if you look at the list of generated staticPaths, you'll see these:
Checklist
pnpm change