feat: implement phase1 table-result, wins/losses and rating layer in race-facade#22
Open
spozitivom wants to merge 2 commits intomasterfrom
Open
feat: implement phase1 table-result, wins/losses and rating layer in race-facade#22spozitivom wants to merge 2 commits intomasterfrom
spozitivom wants to merge 2 commits intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the Phase 1 result layer on top of the existing centralized product write foundation in
race/facade.It introduces a canonical
table_result_recordedpath for:wins / lossesrank_bucketrecalculationThe architecture remains consistent with the previous foundation work:
product_event_serviceproduct_rulesWhat changed
GuestTableResultRecordedto the normalized product event modelstrong_positivemoderate_positiveneutralmoderate_negativestrong_negativewins +1losses +1wins/losseschangerank_bucketrecalculationwins/losseswritesuser_ratingupdatesinternal_guest_table_result_recordedWhat is not included
This PR does not add:
table_result_recordedis production-architected, but current runtime wiring remains intentionally deferred until there is a stable and unambiguous source of truth.Test plan
Verified locally:
Coverage includes:
wins +1losses +1wins/lossesRisks / follow-ups
table_result_recordedmust only be added when there is a stable source of truth