Skip to content

Conversation

@yonggamer
Copy link
Contributor

No description provided.

Copy link
Owner

@REAndroid REAndroid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change as per my review

README.md Outdated
00.396 I: [DECOMPILE] Decode: archive-info.json
00.398 I: [DECOMPILE] Decode: uncompressed-files.json
00.412 I: [DECOMPILE] Decoding: AndroidManifest.xml
00.450 I: [DECOMPILE] public.xml: com.google.android.youtube -> package_1
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid specific names
00.450 I: [DECOMPILE] public.xml: com.test.name -> package_1

README.md Outdated
00.508 I: [DECOMPILE] Res files: resources
02.483 I: [DECOMPILE] Baksmali: classes.dex
05.041 I: [DECOMPILE] Baksmali: classes2.dex
06.976 I: [DECOMPILE] Baksmali: classes3.dex
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Showing only two classes is enough:

00.508 I: [DECOMPILE] Res files: resources
02.483 I: [DECOMPILE] Baksmali: classes.dex
05.041 I: [DECOMPILE] Baksmali: classes2.dex
12.643 I: [DECOMPILE] Extracting root files ...

README.md Outdated
00.852 I: [BUILD] Building dex ...
00.960 I: [BUILD] (1/7) Cached: classes.dex
00.973 I: [BUILD] (2/7) Cached: classes2.dex
00.992 I: [BUILD] (3/7) Cached: classes3.dex
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Showing only two classes is enough

00.852 I: [BUILD] Building dex ...
00.960 I: [BUILD] (1/2) Cached: classes.dex
00.973 I: [BUILD] (2/2) Cached: classes2.dex
01.033 I: [BUILD] Scanning root directory ...

README.md Outdated
00.329 I: [MERGE] Merging: base
00.331 I: [MERGE] Added [base] classes.dex -> classes.dex
00.331 I: [MERGE] Added [base] classes2.dex -> classes2.dex
00.332 I: [MERGE] Added [base] classes3.dex -> classes3.dex
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Showing only two classes is enough:

00.331 I: [MERGE] Added [base] classes.dex -> classes.dex
00.331 I: [MERGE] Added [base] classes2.dex -> classes2.dex
01.289 I: [MERGE] Merging: config.arm64_v8a  

@yonggamer
Copy link
Contributor Author

Please change as per my review

done

@yonggamer yonggamer requested a review from REAndroid May 13, 2025 14:56
@REAndroid REAndroid merged commit 18d3a4d into REAndroid:master May 13, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants