Fix duplicate res/ directory in APK refactor output
#195
+2
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Thanks for the review and suggestions @FlyPhantomFly :)
|
REAndroid
reviewed
May 24, 2025
src/main/java/com/reandroid/apkeditor/refactor/AutoRefactor.java
Outdated
Show resolved
Hide resolved
Owner
|
Perfect, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously:
$ java -jar build/libs/APKEditor-1.4.3.jar x -i input.apk -o out.apk 00.000 I: [REFACTOR] Using: APKEditor version 1.4.3, ARSCLib version 1.3.6 -i = input.apk -o = out.apk __________________ 00.019 I: [REFACTOR] Loading apk: input.apk 00.165 I: [REFACTOR] Auto refactoring ... 00.166 I: [REFACTOR] Validating resource names ... 00.604 I: [REFACTOR] Initializing android framework ... 00.605 I: [REFACTOR] Loading android framework for version: 35 00.757 I: [REFACTOR] Initialized framework: android-35 (15) 00.834 I: [REFACTOR] All resource names are valid 00.834 I: [REFACTOR] Validating file paths ... 01.004 I: [REFACTOR] Auto renamed entries 01.239 I: [REFACTOR] Removed unused table strings Table size changed = 1086216, 1113360 01.239 I: [REFACTOR] Writing apk ... 01.257 I: [REFACTOR] Buffering compress changed files ... 03.808 I: [REFACTOR] Writing files: 1001 03.999 I: [REFACTOR] Writing signature block ... 04.052 I: [REFACTOR] Saved to: out.apk $ unzip -l out.apk | grep 'res/' 744 1981-01-01 01:01 res/res/drawable/mtrl_switch_thumb_unchecked.xml 352 1981-01-01 01:01 res/res/layout/mtrl_calendar_day_of_week.xml 712 1981-01-01 01:01 res/res/layout/mtrl_picker_header_selection_text.xml 828 1981-01-01 01:01 res/res/drawable/indeterminate_static.xml 281 1981-01-01 01:01 res/res/drawable-xhdpi/abc_btn_check_to_on_mtrl_000.png 564 1981-01-01 01:01 res/res/drawable/mtrl_ic_arrow_drop_down.xml 1252 1981-01-01 01:01 res/res/navigation/recordings.xml 318 1981-01-01 01:01 res/res/drawable-xhdpi/abc_text_select_handle_right_mtrl.png 616 1981-01-01 01:01 res/res/anim/design_bottom_sheet_slide_in.xml 1056 1981-01-01 01:01 res/res/drawable/ic_filter.xml 856 1981-01-01 01:01 res/res/drawable/ic_play.xml 1876 1981-01-01 01:01 res/res/layout/fragment_logs_extended_copy.xml 1216 1981-01-01 01:01 res/res/drawable/ic_adb.xml 696 1981-01-01 01:01 res/res/drawable/material_ic_calendar_black_24dp.xml 1088 1981-01-01 01:01 res/res/layout/image_frame.xml 548 1981-01-01 01:01 res/res/mipmap-anydpi-v26/ic_launcher_round.xml 1064 1981-01-01 01:01 res/res/drawable/abc_list_selector_holo_light.xml 2544 1981-01-01 01:01 res/res/layout/preference_dropdown.xml 267 1981-01-01 01:01 res/res/drawable-mdpi/abc_ab_share_pack_mtrl_alpha.9.png 764 1981-01-01 01:01 res/res/menu/main_menu.xml ........Now:
$ java -jar build/libs/APKEditor-1.4.3.jar x -i input.apk -o out.apk 00.000 I: [REFACTOR] Using: APKEditor version 1.4.3, ARSCLib version 1.3.6 -i = input.apk -o = out.apk __________________ 00.019 I: [REFACTOR] Loading apk: input.apk 00.166 I: [REFACTOR] Auto refactoring ... 00.169 I: [REFACTOR] Validating resource names ... 00.578 I: [REFACTOR] Initializing android framework ... 00.578 I: [REFACTOR] Loading android framework for version: 35 00.720 I: [REFACTOR] Initialized framework: android-35 (15) 00.801 I: [REFACTOR] All resource names are valid 00.802 I: [REFACTOR] Validating file paths ... 00.906 I: [REFACTOR] Auto renamed entries 01.107 I: [REFACTOR] Removed unused table strings Table size changed = 1086216, 1109852 01.107 I: [REFACTOR] Writing apk ... 01.126 I: [REFACTOR] Buffering compress changed files ... 03.664 I: [REFACTOR] Writing files: 1001 03.948 I: [REFACTOR] Writing signature block ... 03.977 I: [REFACTOR] Saved to: out.apk $ unzip -l out.apk | grep 'res/' 744 1981-01-01 01:01 res/drawable/mtrl_switch_thumb_unchecked.xml 352 1981-01-01 01:01 res/layout/mtrl_calendar_day_of_week.xml 712 1981-01-01 01:01 res/layout/mtrl_picker_header_selection_text.xml 828 1981-01-01 01:01 res/drawable/indeterminate_static.xml 281 1981-01-01 01:01 res/drawable-xhdpi/abc_btn_check_to_on_mtrl_000.png 564 1981-01-01 01:01 res/drawable/mtrl_ic_arrow_drop_down.xml 1252 1981-01-01 01:01 res/navigation/recordings.xml 318 1981-01-01 01:01 res/drawable-xhdpi/abc_text_select_handle_right_mtrl.png 616 1981-01-01 01:01 res/anim/design_bottom_sheet_slide_in.xml 1056 1981-01-01 01:01 res/drawable/ic_filter.xml 856 1981-01-01 01:01 res/drawable/ic_play.xml 1876 1981-01-01 01:01 res/layout/fragment_logs_extended_copy.xml 1216 1981-01-01 01:01 res/drawable/ic_adb.xml 696 1981-01-01 01:01 res/drawable/material_ic_calendar_black_24dp.xml 1088 1981-01-01 01:01 res/layout/image_frame.xml 548 1981-01-01 01:01 res/mipmap-anydpi-v26/ic_launcher_round.xml 1064 1981-01-01 01:01 res/drawable/abc_list_selector_holo_light.xml 2544 1981-01-01 01:01 res/layout/preference_dropdown.xml 267 1981-01-01 01:01 res/drawable-mdpi/abc_ab_share_pack_mtrl_alpha.9.png 764 1981-01-01 01:01 res/menu/main_menu.xml ........