refactor!: replace WebSocket/TCP transport with Unix socket / Windows named pipe#1699
Open
eitsupi wants to merge 10 commits intoREditorSupport:masterfrom
Open
refactor!: replace WebSocket/TCP transport with Unix socket / Windows named pipe#1699eitsupi wants to merge 10 commits intoREditorSupport:masterfrom
eitsupi wants to merge 10 commits intoREditorSupport:masterfrom
Conversation
Replace the WebSocket-over-TCP IPC between vscode and R sessions with a Unix domain socket (Linux/Mac) or Windows named pipe transport. Changes: - session.ts: create net.Server pipe instead of WebSocket.Server; use NDJSON framing (\n-delimited JSON) for message boundaries; remove token-based authentication (filesystem permissions suffice) - rTerminal.ts: pass SESS_PIPE env var instead of SESS_PORT + SESS_TOKEN - sess/R/server.R: connect via processx::conn_connect_unix_socket(); drive message dispatch through a later::later() polling loop - sess/R/dispatch.R: send via processx::conn_write() + NDJSON framing - sess/DESCRIPTION: swap websocket dep for processx (>= 3.5.0); add testthat to Suggests - sess/tests/testthat/test-ipc.R: unit tests for socket round-trip, dispatch_message routing, and ipc_write guard
eitsupi
changed the title
eitsupi
force-pushed
the
feat/ipc-named-pipe
branch
from
b50c828 to
fdc193b
Compare
eitsupi
commented
May 5, 2026
| # Derive file path for fallback/reconnection | ||
| # Fallback: read from session JSON file written by the extension | ||
| pid <- Sys.getpid() | ||
| home <- path.expand("~") |
Contributor
Author
There was a problem hiding this comment.
This should refer to My Documents on Windows, so it's probably not what you intended.
Member
There was a problem hiding this comment.
Ya, it is not ideal. It may not be the same "~" inferred by VSCode.
eitsupi
changed the title
Member
|
thanks for working on it, didn't know that |
Member
|
This branch works for me on macOS. It looks like the dependencies are reduced 👍 . |
Member
|
It would be ok if either eitsupi#1 (which fixes the use case of unmanaged R session) could be merged into this PR, or after this PR being merged into master and I resubmit that PR based on latest master. |
Improve attach
Contributor
Author
|
Merged, thank you! |
randy3k
reviewed
May 9, 2026
| # Derive file path for fallback/reconnection | ||
| # Fallback: read from session JSON file written by the extension | ||
| pid <- Sys.getpid() | ||
| home <- path.expand("~") |
Member
There was a problem hiding this comment.
Ya, it is not ideal. It may not be the same "~" inferred by VSCode.
| await fs.writeFile(scriptPath, buildAttachSessionScript(pipePath, sessPath), { encoding: 'utf-8' }); | ||
| attachSessionScriptPath = scriptPath; | ||
|
|
||
| return `source(${asRStringLiteral(scriptPath)})`; |
|
|
||
| function buildAttachSessionScript(pipePath: string, sessPath: string): string { | ||
| return [ | ||
| 'local({', |
Member
There was a problem hiding this comment.
i wonder how we could make it consistent with the install_sess.R.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the WebSocket-over-TCP IPC between vscode and R sessions with a Unix domain socket (Linux/Mac) or Windows named pipe transport.