[renkun-ken]

The EJS 7 upgrade makes the namespace imports in the httpgd viewer and local help previewer resolve render to undefined when bundled. Plot refreshes and added thumbnails fail, and local package index previews cannot render. Use EJS's default export in both viewers to restore these paths while retaining EJS 7.

Non-watch builds now fail if any of the four esbuild contexts reports a warning. All contexts are disposed after rebuilding, including when a build fails. Watch mode continues to report warnings without treating them as build failures.

Fixes #1910.

Validation:

• Development and production builds, TypeScript checking, TypeScript and changed JavaScript lint, formatting, and diff checks pass.
• Temporary warning injection confirmed that both build modes fail for a general warning in each of the four contexts, while watch mode allows warnings in all four.
• Temporarily restoring the original EJS namespace imports during bundling makes both build modes fail. The final production extension bundle contains zero (void 0)(...) calls.

[eitsupi]

ChatGPT review — Approved

The EJS import fix addresses #1910. I have two non-blocking suggestions:

1. Fail builds on all esbuild warnings. The underlying CI issue was that warnings did not cause build failures. Rather than promoting only "import-is-undefined" to an error, I suggest treating any esbuild warning as a build failure across all four build contexts (excluding watch mode).

2. Simplify the regression tests. The 135-line test harness introduces custom bundling, VM execution, and extensive mocking. Given that esbuild already detected the original problem, enforcing zero warnings should provide sufficient protection against this specific regression without the additional maintenance burden.

Neither suggestion needs to block this urgent fix.

[renkun-ken]

Thanks for the review. Both suggestions are addressed in da213c8:

• Non-watch builds now fail on any esbuild warning from the extension, session agent, Interactive renderer, or webview context. The contexts are disposed in finally; watch mode continues to report warnings without failing the build.
• Removed the 135-line bundling/VM regression harness and restored the existing Node test command.

Local development and production builds, TypeScript checking, lint, formatting, and diff checks pass. Temporary probes confirmed that a general warning in each of the four contexts fails both build modes, that restoring the original EJS namespace imports also fails both modes, and that watch mode allows warnings across all four contexts. The final production bundle contains zero (void 0)(...) calls.

For this revision, hosted build and formatting checks have passed; lint and the three platform test jobs are still running.

[eitsupi]

@renkun-ken Thanks for working on this.
Will you create a new release?

[eitsupi]

#1913