fix: align Gemma dtype before RoPE - #2
Open
wilburx813 wants to merge 1 commit into
Open
Conversation
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This issue was observed when running Pi0.5 inference through RPent. Originally reported in RLinf/RPent#131. The model loaded successfully, but inference failed with:
This regression was introduced while porting the custom Gemma implementation from Transformers 4.53 to 4.57. The existing BF16 cast was moved after RoPE construction, causing RoPE to remain FP32 while the attention values and prefix KV cache were BF16.
The resulting dtype mismatch caused the attention matmul to fail.
Fix
Restore the original ordering by moving the existing BF16 cast before RoPE construction.
This keeps the RoPE and attention tensors in BF16 without adding new casting logic.
Verification
(1, 5, 7).