Repository navigation
manual-bbの失敗修正とreadiness入力仕様の確定 - #26
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 190a716427
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| generated.push(invariantsPath); | ||
|
|
||
| if (emitFormats.includes("sarif")) { | ||
| const sarifPath = writeSarifReport(absoluteOutDir, reportedFindings, { |
There was a problem hiding this comment.
Pass the actual producer version to the SARIF reporter
When analyze runs with its default output, --emit all, or --emit sarif, this invokes a reporter whose version is hard-coded to 0.1.0 in src/reporters/sarif-reporter.ts, so results.sarif advertises a different producer version from the accompanying findings and audit artifacts (currently 1.6.0). This gives version-aware code-scanning and provenance consumers incorrect metadata; pass reportedFindings.tool.version/the CLI version through to the reporter instead.
Useful? React with 👍 / 👎.
| riskRegister, | ||
| testSeeds, | ||
| }); | ||
| generated.push(sarifPath); |
There was a problem hiding this comment.
Canonicalize volatile SARIF fields before recording stable_hash
Adding results.sarif to generated causes buildGeneratedArtifactRefs to publish a stable_hash for it, but canonicalizeForStableHash only parses files ending in .json; for .sarif it uses line filtering that does not remove the reporter's startTimeUtc, endTimeUtc, or properties.runId. Consequently two otherwise identical analyses produce different stable hashes for this newly emitted-by-default artifact, defeating the audit hash's deterministic-comparison purpose. Handle SARIF as JSON and remove its volatile equivalents before hashing.
Useful? React with 👍 / 👎.
code-to-gate PR ReviewGate Verdict
Blocking Reasons
Acceptable Risks
Suggested Tests
Spec Drift
Drift Budget
Evidence Links
Suppression / Baseline Summary
Gate Explainability
Generated by code-to-gate v1.6.0 |
manual-bbで確認したbaseline誤参照、抑制YAMLと不正期限、policy入力検証、readiness IDとwarn_only、emit/SARIF、help、Viewerのversion表示を修正します。関連するfilter_low=falseの評価漏れも修正し、元の105ケースへ対照を追加しました。
未確定だったpartial_warning_thresholdは、v1に欠落割合の分子・母数がないため予約設定と仕様化します。completenessとallow_partialによる判定を12組合せで検証し、READMEのimport→analyze→export手順とrename表現も同期しました。artifact schemaは変更していません。
検証結果:
検収記録:
docs/acceptance/AC-20260911-05-manual-bb-fixes.md。Windowsローカル・非LLM主要フローのagentによる検収です。公開versionは1.6.0を維持し、変更はUnreleasedに記録します。Birdseyeの生成ID更新によりcapsule群も再生成しています。