Skip to content

CK FA Minor Refactor#617

Merged
Micky774 merged 1 commit into
devfrom
zain/ck/minor-refactor
Jun 11, 2026
Merged

CK FA Minor Refactor#617
Micky774 merged 1 commit into
devfrom
zain/ck/minor-refactor

Conversation

@Micky774

@Micky774 Micky774 commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Description

Minor refactoring of workspace setting, env getting, and mask classification

Fixes # (issue)

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring

Changes

Please list the changes introduced in this PR:

  • Factors out workspace setting into common utility
  • Replaces on-site redundant env getting w/ common utility
  • Factors out is_padding and is_causal as common utilities

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@Micky774 Micky774 merged commit 2c2795e into dev Jun 11, 2026
10 of 11 checks passed
@Micky774 Micky774 deleted the zain/ck/minor-refactor branch June 11, 2026 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-level 3 CI test level 3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants