[JIT][Bugfix] Make blob codegen cache publication transactional - #4800
Open
Ruye-aa wants to merge 1 commit into
Open
[JIT][Bugfix] Make blob codegen cache publication transactional#4800Ruye-aa wants to merge 1 commit into
Ruye-aa wants to merge 1 commit into
Conversation
Signed-off-by: aiyang.ay <aiyang.ay@alibaba-inc.com>
Contributor
🏷️ CI GuideRuns automatically on every PR:
Extended tests (opt-in via labels):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
source cache if publication fails;
healthy
.so;Problem
build_module()currently writes codegen output directly into the canonicalblob/directory and ignores the
os.system()return code. It also removes the installedmodule before a replacement has compiled. A failed or interrupted generator can
therefore leave partial sources that are compiled or reused, while also destroying the
last known-good binary.
This was observed on the CK MHA JIT path as a truncated
fmha_fwd_api.cppwith nomatching dispatch branch, followed by persistent
invalid argument for fmha_fwdfailures until the cache was deleted.
Implementation
The change moves generator execution into
aiter/jit/utils/jit_cache.py:subprocess.run(..., check=True)propagates generator failure;.cppor.cusource;blob/after successful compilation, withrollback if directory publication fails;
os.replace().Tests
The regression tests are CPU-only and cover:
.sowhen copying the replacement fails.GPU compilation and CK MHA runtime validation are left to the upstream CI because the
local development host has no ROCm GPU.
Closes #4799