a4w4 improve - #4801
Merged
yadaish merged 5 commits intoAug 17, 2026
Merged
Conversation
yadaish
commented
Aug 17, 2026
| # The dedicated FP4 instruction consumes two adjacent 16-column weight | ||
| # fragments and produces a 32-column result. Keep the epilogue's existing | ||
| # 16-column view by splitting each vec16 accumulator after the K loop. | ||
| mma_n_rep = wmma_n_rep // 2 if a_is_fp4 else wmma_n_rep |
Contributor
Author
There was a problem hiding this comment.
bad code, we should use right WMMA_N instead of hacking
yadaish
commented
Aug 17, 2026
| a_off0 = blk_m64 * A_KROW | ||
| b_off0 = b_outer_row * Kp16 | ||
| sb_off0 = (blk_n64 // 32) * SB_OUTER_STRIDE + sb_batch_off | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Technical Details
Test Plan
Test Result
Submission Checklist