[build_supp] Fixes to derive_rocm_path for ucc build#2169
Merged
Conversation
Contributor
dpalermo
commented
Apr 17, 2026
dpalermo
commented
- Fixes failures seen in the nightly build
- Use AOMPHIP if provided
- Use realpath/../.. since llvm is a symlink
- Also set HIPCC as ucc otherwise defaults to /usr/bin/amdclang
- Add checkversion for rocmopenmpi, ucx, ucc (avoids unnecessary rebuilds)
- Fixes failures seen in the nightly build - Use AOMPHIP if provided - Use realpath/../.. since llvm is a symlink - Also set HIPCC as ucc otherwise defaults to /usr/bin/amdclang - Add checkversion for rocmopenmpi, ucx, ucc (avoids unnecessary rebuilds)
dpalermo
requested review from
carlobertolli,
estewart08,
gregrodgers,
ronlieb and
zGoldthorpe
as code owners
Contributor
Author
|
Fixes needed after #2140 |
Contributor
Author
|
Also no longer exits if HIP install not found...just skip the components that needed HIP. |
ronlieb
pushed a commit
that referenced
this pull request
Apr 18, 2026
- Fixes failures seen in the nightly build - Use AOMPHIP if provided - Use realpath/../.. since llvm is a symlink - Also set HIPCC as ucc otherwise defaults to /usr/bin/amdclang - Add checkversion for rocmopenmpi, ucx, ucc (avoids unnecessary rebuilds)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.