fix(utils_lib): detect MI350 by device ID when rocm-smi omits the model name - #316
Open
speriaswamy-amd wants to merge 3 commits into
Open
Conversation
…el name On some driver / rocm-smi versions an MI350 node reports no marketing-name string anywhere in `rocm-smi -a` — only "Device ID: 0x75a0" and "GFX Version: gfx950". get_model_from_rocm_smi_output then fell through to its conservative 'mi300x' default, so MI350 nodes silently picked the MI300X entry in expected_results and were graded against the wrong performance threshold. Adds a Device ID fallback after the existing marketing-name checks, so the name-based path is unchanged when a name is present. Adds unit tests covering all four marketing names, the device-ID fallback, and the unrecognized-input default. Co-Authored-By: Claude <noreply@anthropic.com>
…-mi350-detection (bring branch up to date)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 3 of 12 in a stack that replaces #184. Base: #315.
Why
On some driver / rocm-smi versions an MI350 node reports no marketing-name string anywhere in
rocm-smi -a— onlyDevice ID: 0x75a0andGFX Version: gfx950.get_model_from_rocm_smi_outputthen fell through to its conservative'mi300x'default, so MI350 nodes silently picked the MI300X entry inexpected_resultsand were graded against the wrong performance threshold.What changed
cvs/lib/utils_lib.py— added aDevice ID: 0x75a0fallback after the existing marketing-name checks, so the name-based path is unchanged whenever a name is present.cvs/lib/unittests/test_utils_lib.py— tests for all four marketing names, the device-ID fallback, and the unrecognized-input default.