chore(utils_lib): add cvs_package_root(), dedupe ad-hoc root resolution - #335
Open
speriaswamy-amd wants to merge 1 commit into
Open
Conversation
run_config_paths.py and copy_config_plugin.py each hand-rolled their own `os.path.dirname(os.path.abspath(cvs.__file__))` / `dirname(dirname(__file__))` to find the installed cvs package directory. Extract the shared helper and point both call sites at it. AIMVT-276.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 2 of 14 in a stack for AIMVT-276. Base: #334.
Why
run_config_paths.pyandcopy_config_plugin.pyeach independently computed the installed cvs package directory — one viaos.path.dirname(os.path.abspath(cvs.__file__)), the other viadirname(dirname(__file__)). A third call site (the upcoming config parameter registry) needs the same path, which would make a third divergent implementation.What changed
cvs/lib/utils_lib.py— addedcvs_package_root().cvs/lib/run_config_paths.py,cvs/cli_plugins/copy_config_plugin.py— switched their existing ad-hoc logic to call it.cvs/lib/unittests/test_utils_lib.py— added tests for the new helper.