feat(parsers): add pydantic schema for the RCCL config section - #338
Open
speriaswamy-amd wants to merge 1 commit into
Open
feat(parsers): add pydantic schema for the RCCL config section#338speriaswamy-amd wants to merge 1 commit into
speriaswamy-amd wants to merge 1 commit into
Conversation
First of the pilot suites for AIMVT-276 (cvs man): pydantic models become the single source of truth for a config section's parameters instead of the _comment_*/_example_* keys currently living inside the JSON. Defaults are taken from the .get(key, default) call sites in rccl_lib.py and cvs/tests/rccl/, not the sample config -- several disagree with what actually ships (e.g. net_dev_list and ucx_tls are read but never appear in any sample). New cvs/parsers/config_schemas/ subpackage: schemas.py is already ~1300 lines, so per-suite models get their own module, re-exported from config_schemas/__init__.py. AIMVT-276.
speriaswamy-amd
force-pushed
the
speriaswamy/cvsman-05-rccl-schema
branch
from
August 14, 2026 20:33
75fd4b0 to
8620a2f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 5 of 14 in a stack for AIMVT-276. Base: #337.
Why
This is the first pilot suite for AIMVT-276 ("implement
cvs man"). Today RCCL config parameters are documented, unevenly, via_comment_*/_example_*pseudo-keys inside the JSON. This PR givesrccla pydantic model so a later PR in this stack can introspect it forcvs man— and deletes the JSON clutter once that lands.Defaults are taken from the
.get(key, default)call sites inrccl_lib.py/cvs/tests/rccl/, not the sample config — several disagree with what actually ships.net_dev_listanducx_tlsare read at runtime but appear in no shipped sample; they're documented here for the first time.What changed
cvs/parsers/config_schemas/rccl.py(new) —RcclMpiParams,RcclTestParams,RcclCvsParams,RcclConfigFile.cvs/parsers/config_schemas/__init__.py(new) — re-export point;schemas.pyis already ~1300 lines, so per-suite models get their own module here instead of growing it further.All models are
extra="allow"and documentation-only — not wired into runtime validation in this stack, since RCCL configs have never been validated and AGENTS.md requires backward compatibility with existing customer configs.