test(parsers): add config_registry drift guard - #347
Open
speriaswamy-amd wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 14 of 14 in a stack for AIMVT-276.
Base: #346.
Why
Nothing previously enforced that
cvs man's registry (config_registry.py)stays in sync with the pydantic schemas and shipped sample configs. Without
a guard, a schema field could go undocumented, a sample could drift out of
sync with its schema, or a stripped
_comment_*/_example_*key couldsilently creep back in — and nobody would notice until a customer hit it.
What changed
cvs/parsers/unittests/test_config_registry.py, asserting forevery suite in
TEST_CONFIG_DOCS:tracked exception:
rccl_config.json's root-levelresultsblock,which
rccl_lib.pynever reads from that location — a pre-existingfunctional quirk, not something to paper over by mis-documenting it)
_comment_*/_example_*documentation keys