update model discovery to handle tags in subdirectories for madengineV2#85
Open
leconcio wants to merge 2 commits intocoketaste/refactor-disfrom
Open
update model discovery to handle tags in subdirectories for madengineV2#85leconcio wants to merge 2 commits intocoketaste/refactor-disfrom
leconcio wants to merge 2 commits intocoketaste/refactor-disfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
update model discovery to handle tags in subdirectories for AIMODELS-518
Technical Details
Added "tags" for subdirectory model dictionary as {SUBDIR}/{tag} to enable user to isolate models in subdirectory. Also added some input validation to make additional-context and additional-context-file mutually exclusive
Test Plan
Check if subdirectory models can be filtered using tags
Test Result
Submission Checklist