Add debug messages to calculateBlockGemmPerformanceParameters#2200
Open
pabloantoniom wants to merge 2 commits intodevelopfrom
Open
Add debug messages to calculateBlockGemmPerformanceParameters#2200pabloantoniom wants to merge 2 commits intodevelopfrom
pabloantoniom wants to merge 2 commits intodevelopfrom
Conversation
pabloantoniom
requested review from
dhernandez0,
justinrosner,
mirza-halilcevic,
stefankoncarevic and
umangyadav
umangyadav
approved these changes
Jan 7, 2026
umangyadav
approved these changes
Jan 7, 2026
|
|
||
| if (param.gemmMPerThread < 2 || param.gemmMPerThread > 4) | ||
| if (param.gemmMPerThread < 2 || param.gemmMPerThread > 4) { | ||
| LLVM_DEBUG(llvm::dbgs() << "gemmMPerThread is not in the range [2, 4]\n"); |
Member
There was a problem hiding this comment.
These are only for non-accel. Can you add such messages for Accel as well?
Contributor
Author
There was a problem hiding this comment.
Good point, thanks
justinrosner
approved these changes
Jan 7, 2026
dhernandez0
approved these changes
Jan 7, 2026
pabloantoniom
force-pushed
the
pablo-dbg-msg
branch
from
8b957d3 to
9d29920
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
I get
Incoherent blockGemm tuning parameter sizeerrors very frequently and I always keep adding this debug messages to see what's wrong.Technical Details
Added debug messages
Test Plan
No new test was added
Test Result
All test pass
Submission Checklist