-
Notifications
You must be signed in to change notification settings - Fork 10
feat(install): add --yes flag for non-interactive SDK installation (EAI-7956) #273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
50edb1e
feat(install): add --yes flag for non-interactive SDK installation an…
r0x0r 0295ebf
test(install): cover the host-vs-TheRock version-note explanation (EA…
r0x0r 46d14a8
install: address --yes review — propagate flag, fix host-newer parse,…
r0x0r 82281a6
docs(install): document --yes for SDK reinstall and cover chat/MCP pl…
r0x0r 62105bb
test(e2e): pass --yes on the remaining shared-tree SDK install (EAI-7…
r0x0r 44e849a
fix(install): add --yes to the rocmd MCP install_sdk spawn and correc…
r0x0r 3244d96
fix(install): say "replace as the active default" in the --yes help (…
r0x0r 5701a8f
Merge origin/main into rocm-latest-version (EAI-7956)
r0x0r 04849a2
fix(install): gate the SDK consent prompt on the active default runti…
r0x0r ee8fac3
style: rustfmt the active-default gate test and step
r0x0r 27d4bff
Merge origin/main into rocm-latest-version
r0x0r fecf93d
Merge origin/main into rocm-latest-version (EAI-7956)
r0x0r 76c6aa3
fix(install): stop injected --yes from approving sudo package install…
r0x0r d6435b4
fix(install): credit the consent flag that was actually passed (EAI-7…
r0x0r d40c420
Merge remote-tracking branch 'origin/main' into HEAD
r0x0r acec516
Merge origin/main into rocm-latest-version
r0x0r 9ee039a
fix(install): fail the consent gate closed and carry --yes through fr…
r0x0r b4e78e2
docs(readme): link the install-consent section by URL, not a page anchor
r0x0r c593462
fix(install): fail the consent gate closed on both default_runtime_id…
r0x0r aa554f3
fix(install): blame only the active key's own unreadable manifest, na…
r0x0r 4a53615
fix(install): strip an attached-value --yes, disclose the injected co…
r0x0r 27eef66
test(install): cover the consent disclosure end to end, honest strip …
r0x0r 2cf687e
Merge origin/main into rocm-latest-version
r0x0r ddc8f7a
Merge origin/main into rocm-latest-version
r0x0r 49ad726
test(e2e): reach the consent gate for a cross-family install (EAI-7956)
r0x0r dfeffcb
Merge origin/main into rocm-latest-version
r0x0r bef9ea4
docs: cover the SDK install consent gate in the testing guides (EAI-7…
r0x0r 34f7eb4
docs: correct two comments the consent gate work falsified (EAI-7956)
r0x0r 2c99788
Merge origin/main into rocm-latest-version
r0x0r File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This paragraph and the one at
:266-283explain the same three facts — the gate, the narrow flag, and what--yesadditionally approves — with the second running about 3x the length. Both are accurate today; the risk is that a future reword updates one and not the other, which is the failure mode this PR exists to prevent elsewhere. Worth collapsing to one authoritative spot with a pointer.