Skip to content

fix(parser), test health, dead code, DI/nav and docs cleanup - #2

Open
Rafael-VH wants to merge 9 commits into
refactor/remove-network-modulesfrom
refactor/cleanup-and-parser-fixes
Open

Rafael-VH wants to merge 9 commits into
refactor/remove-network-modulesfrom
refactor/cleanup-and-parser-fixes

Conversation

@Rafael-VH

Copy link
Copy Markdown
Owner

Summary

  • Fixes mlbb_parser: matches Spanish label-first total games (Partidas jugadas/totales) and stops the MVP regex from capturing across lines.
  • Test health: awaits the getBadge assertion (bloc_test 10 runs verify after close()), replaces the stale counter smoke test with a boot smoke test (splash → MainScreen).
  • Removes dead code: zero-import widgets/copy helpers, salomon_bottom_bar dependency.
  • DI/nav consistency: drops the phantom http client, aligns totalDestinations with the real 3 destinations, moves base_usecase to core/usecases.
  • Docs: removes stale Supabase and removed-module references from README.

Changes Table

Area Change
lib/features/parser/utils/mlbb_parser.dart Regex fixes: [\d,]+ total games, [^\S\n]* MVP separator
test/core/utils/stats_parser_test.dart Strengthened cases (1500 total games, 320 mvpCount, KDA 4.5)
test/features/navigation/bloc/navigation_bloc_test.dart await on badge assertion instead of verify
test/widget_test.dart Counter smoke test replaced with boot smoke test
lib/core/widgets/**, lib/core/usecases/copy_to_clipboard.dart Deleted zero-import dead code
lib/core/injection/injection_container.dart Removed phantom http client, totalDestinations: 3
lib/core/usecases/base_usecase.dart Moved from upload feature (4 imports updated)
lib/features/navigation/** Aligned destinations, removed _PlaceholderPage
pubspec.yaml / pubspec.lock Dropped salomon_bottom_bar
README.md Dropped stale Supabase/removed-module references

Test Plan

  • flutter test — 191/191 pass (includes parser, nav, boot smoke)
  • flutter analyze — 0 errors (11 pre-existing infos)
  • dart format applied

Chain Context

Field Value
Chain insight-offline-cleanup
Tracker PR Not needed (2-PR chain)
Position 2 of 2
Base refactor/remove-network-modules
Depends on PR A (remove network modules)
Follow-up None
Review budget 1263 changed lines (67+/1196-) / 400
Starts at PR A head refactor/remove-network-modules
Ends with Green suite (191/191), offline app cleaned, docs consistent

Chain Overview

main
 └── #A Remove network modules
      └── 📍 #B This PR: parser fixes + test health + cleanup + docs

Scope

  • Includes: parser correctness, test suite health, dead code removal, DI/nav consistency, docs sync
  • Excludes: app features, dependencies beyond salomon_bottom_bar

Autonomy

  • CI-equivalent checks pass for this branch (flutter test 191/191, flutter analyze 0 errors)
  • This PR has one deliverable scope (green + clean offline app)
  • This PR can be rolled back by reverting the branch
  • Tests/docs ship with the code they explain

size:exception rationale: both PRs exceed 400 changed lines because the diffs are atomic deletions of entire dead/network modules that cannot be sliced coherently; split chosen by maintainer at 2 deliverable units.

Rafael-VH and others added 7 commits September 7, 2026 02:24
Adds docs/index.html dashboard with a diagrams.json manifest so new
interactive diagrams can be registered as they are generated, plus the
first architecture diagram (Insight code map) and its archify spec.

Co-authored-by: CommandCodeBot <noreply@commandcode.ai>
Rafael-VH and others added 2 commits September 16, 2026 17:59
Adds docs/index.html dashboard with a diagrams.json manifest so new
interactive diagrams can be registered as they are generated, plus the
first architecture diagram (Insight code map) and its archify spec.

Co-authored-by: CommandCodeBot <noreply@commandcode.ai>
Groups diagrams into ordered sections (Arquitectura, Frontend, Datos,
OCR & Parser, Navegación, Configuración) so each area of the project
can accumulate multiple diagrams over time. Sections render with a
header and description; empty sections show a placeholder.

Co-authored-by: CommandCodeBot <noreply@commandcode.ai>

This branch was successfully deployed

1 active deployment
github-pages 047ca377 Deployed Sep 16, 2026 by Rafael-VH via deploy #2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant