Skip to content

fix: Use dominant axis for keyboard move direction #10030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
microbit-robert wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −5
Open

fix: Use dominant axis for keyboard move direction #10030

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions packages/blockly/core/dragging/block_drag_strategy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1142,11 +1142,15 @@ export class BlockDragStrategy implements IDragStrategy {
const actualPosition = this.block.getRelativeToSurfaceXY();
const delta = Coordinate.difference(newLocation, actualPosition);
const {x, y} = delta;

if (x < 0) return Direction.LEFT;
if (x > 0) return Direction.RIGHT;
if (y < 0) return Direction.UP;
if (y > 0) return Direction.DOWN;
// Pick the dominant axis rather than testing x before y. A keyboard move is
// single-axis by intent, but the delta is round-tripped through pixels
// (KeyboardMover scales up by workspace.scale, Dragger scales back down), so
// at any zoom != 1 the axis that should be zero carries ~1e-14 of
// floating-point residue. Comparing magnitudes keeps that residue from
// outranking the real movement and flipping e.g. a DOWN press to RIGHT.
if (Math.abs(x) > Math.abs(y))
return x < 0 ? Direction.LEFT : Direction.RIGHT;
if (Math.abs(y) > 0) return y < 0 ? Direction.UP : Direction.DOWN;
return Direction.NONE;
}

Expand Down
Loading