Repository navigation
Update roles when ownership transfer is accepted - #1046
Merged
Merged
Conversation
As is the pattern elsewhere, we are archiving the old owner role rather than deleting it. When promoting the nominee, we use `Role.unscoped[...]` to ensure that existing archived owner roles don't cause problems in situations where ownership has been transferred back and forth (and therefore the nominee has an existing, but archived, owner role).
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
Test coverage93.78% line coverage reported by SimpleCov. |
raspberrypiherokubot
temporarily deployed
to
editor-api-p-new-owner--w4fg99
October 5, 2026 13:35
Inactive
mwtrew
marked this pull request as ready for review
October 5, 2026 13:57
![macroscopeapp[bot]](https://avatars.githubusercontent.com/in/900172?s=60&v=4){kind=small}
zetter-rpf
reviewed
Oct 6, 2026
zetter-rpf
reviewed
Oct 6, 2026
zetter-rpf
approved these changes
Oct 6, 2026
This means there's no risk of a different transfer being loaded between the controller and concept. `requires_new` is used in Accept's transaction so it doesn't use the outer transaction, which can result in surprising behaviour. See: https://api.rubyonrails.org/v8.0/classes/ActiveRecord/Transactions/ClassMethods.html#module-ActiveRecord::Transactions::ClassMethods-label-Nested+transactions
mwtrew
force-pushed
the
new-owner-accepts-transfer-request
branch
from
October 6, 2026 12:32
6a914f3 to
d06f1e8
Compare
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
What's changed?