Minor plotting modifications#134
Merged
TomGeorge1234 merged 1 commit intoRatInABox-Lab:mainfrom Jan 8, 2026
Merged
Conversation
Collaborator
|
Hey!
|
Contributor
Author
|
Sounds good to me! Will go implement that. |
…using fill_between at a lower resolution (very large polycollections can cause problems). Added wall_lw kwarg retrieval to Environment.plot_environment() to allow control over the linewidth of plotted walls.
Collaborator
|
awesome, let's ship it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue 1: When plotting the shaded area in
mountain_plot()usingfill_between(), very large polycollections may be created (given thousands of time points). This can cause problems (i.e., thefill_between()object corrupting an illustrator file).=> Solution: Enabled a
skipratefor plotting shade inmountain_plot()usingfill_between(). Allows the user to reduce the resolution of the shaded area.Issue 2: Wall thickness cannot be adjusted for different subplot sizes.
=> Solution: Added a
wall_lwkeyword argument toEnvironment.plot_environment()to allow users to control the linewidth of the walls.