Added animation hold#136
Merged
TomGeorge1234 merged 1 commit intoRatInABox-Lab:mainfrom Apr 9, 2026
Merged
Conversation
Collaborator
|
honestly it seems fine to me! We can always look into it again if the inefficency becomes an issue. thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added an option when creating animations (trajectory or rate timeseries) to hold the last frame for a few seconds.
You'll notice that I made
framesan array instead of a lazy iterable.frames = np.concatenate([np.arange(frames), np.repeat(frames - 1, hold_n)])This is not the most memory efficient approach, but I couldn't find a way to make
framesa lazy iterable.itertools.chaincan chain iterables, but then you can't calllen()on them, which matplotlib's animation function needs to do. This seemed like a reasonable compromise. If the user sets hold to 0,framesis left as a lazy iterable so previous behaviour is unchanged.