Skip to content

fix(q): distinguish decode failures from Q errors #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
belowzeroff wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(q): distinguish decode failures from Q errors #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c7d98f3
fix(q): harden codec and connection handling
Oct 4, 2026
e675994
fix(q): distinguish decode failures from Q errors
Oct 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions embed/rayforce_q.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,8 +131,8 @@ static ray_t *qb_connect(ray_t **args, int64_t n) {
return ray_error("type", ".q.connect: password must be a string");

char user[128], password[128];
ray_t *arg_err = q_copy_str_arg(n >= 3 ? args[2] : NULL, "user", user,
sizeof user);
ray_t *arg_err =
q_copy_str_arg(n >= 3 ? args[2] : NULL, "user", user, sizeof user);
if (arg_err)
return arg_err;
arg_err = q_copy_str_arg(n >= 4 ? args[3] : NULL, "password", password,
Expand All @@ -146,8 +146,7 @@ static ray_t *qb_connect(ray_t **args, int64_t n) {
if (!tok)
return ray_error("type", ".q.connect: timeout must be an integer");
if (timeout_value < 0 || timeout_value > INT_MAX)
return ray_error("range",
".q.connect: timeout must be in 0..INT_MAX ms");
return ray_error("range", ".q.connect: timeout must be in 0..INT_MAX ms");
timeout_ms = (int)timeout_value;
}

Expand Down Expand Up @@ -185,6 +184,8 @@ static ray_t *qb_send(ray_t *handle, ray_t *msg) {
ray_poll_t *poll = q_poll();
if (poll != NULL)
return q_conn_send(poll, fd, msg);
if (fd > INT_MAX)
return ray_error("range", ".q.send: handle exceeds the socket range");

char err[128] = {0};
ray_t *res = q_send((int)fd, msg, err, sizeof err);
Expand All @@ -208,9 +209,11 @@ static ray_t *qb_close(ray_t *handle) {

ray_poll_t *poll = q_poll();
if (poll != NULL) {
if (ray_poll_get(poll, fd) == NULL)
return ray_error("handle", ".q.close: not an open connection");
if (!q_conn_is_handle(poll, fd))
return ray_error("handle", ".q.close: not an open Q connection");
q_conn_close(poll, fd);
} else if (fd > INT_MAX) {
return ray_error("range", ".q.close: handle exceeds the socket range");
} else if (q_close((int)fd) < 0) {
return ray_error("handle", ".q.close: not an open connection");
}
Expand Down Expand Up @@ -252,7 +255,8 @@ int64_t q_serve_from_args(ray_poll_t *poll, int argc, char **argv) {
break;
if (strcmp(argv[i], "-q") == 0 || strcmp(argv[i], "--q-serve") == 0) {
if (i + 1 >= argc) {
fprintf(stderr, "q: missing port after %s (expected 1..65535)\n", argv[i]);
fprintf(stderr, "q: missing port after %s (expected 1..65535)\n",
argv[i]);
return -1;
}
int port = 0;
Expand Down
Loading
Loading