Skip to content

Store favourite comments per-activity #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Terrance wants to merge 6 commits into
base: dev
Choose a base branch
from
+1,387 −6
Draft

Store favourite comments per-activity #457

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7629396
Create record type to favourite comment repo
Terrance Mar 18, 2026
609a0f1
Add type to comment database migration
Terrance Mar 18, 2026
5e502b2
Handle activity-linked favourites in hints
Terrance Mar 18, 2026
28ecf1c
Toggle type to comment relation with favourite button
Terrance Mar 18, 2026
5338383
Add type to comment to backup/restore
Terrance Mar 18, 2026
30cd135
Move shared favourite logic to interactor
Terrance Mar 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions ...m/example/util/simpletimetracker/core/interactor/RecordCommentSearchViewDataInteractor.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import com.example.util.simpletimetracker.core.repo.ResourceRepo
import com.example.util.simpletimetracker.core.viewData.CommentFilterTypeViewData
import com.example.util.simpletimetracker.domain.base.CommentFilterType
import com.example.util.simpletimetracker.domain.favourite.interactor.FavouriteCommentInteractor
import com.example.util.simpletimetracker.domain.favourite.interactor.RecordTypeToFavouriteCommentInteractor
import com.example.util.simpletimetracker.domain.prefs.interactor.PrefsInteractor
import com.example.util.simpletimetracker.domain.record.interactor.RecordInteractor
import com.example.util.simpletimetracker.domain.record.interactor.RunningRecordInteractor
Expand All @@ -24,6 +25,7 @@ class RecordCommentSearchViewDataInteractor @Inject constructor(
private val prefsInteractor: PrefsInteractor,
private val recordInteractor: RecordInteractor,
private val favouriteCommentInteractor: FavouriteCommentInteractor,
private val recordTypeToFavouriteCommentInteractor: RecordTypeToFavouriteCommentInteractor,
private val runningRecordInteractor: RunningRecordInteractor,
) {

Expand All @@ -35,7 +37,7 @@ class RecordCommentSearchViewDataInteractor @Inject constructor(
val result = mutableListOf<ViewHolderType>()

val similar = getSimilarData(comment)
val favourite = getFavouriteData()
val favourite = getFavouriteData(typeId)
val last = getLastCommentsData(typeId)

val filters = getFilters(
Expand Down Expand Up @@ -121,8 +123,11 @@ class RecordCommentSearchViewDataInteractor @Inject constructor(
}
}

private suspend fun getFavouriteData(): List<ViewHolderType> {
return favouriteCommentInteractor.getAll()
private suspend fun getFavouriteData(
typeId: Long,
): List<ViewHolderType> {
val comments = favouriteCommentInteractor.getAll()
return recordTypeToFavouriteCommentInteractor.filterFavourites(typeId, comments)
.map { RecordCommentViewData.Favourite(it.comment) }
}

Expand Down
Loading