delete rows by reference #7536
delete rows by reference #7536
Conversation
ben-schwen
requested review from
HughParsonage,
MichaelChirico and
tdhock
as code owners
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7536 +/- ##
==========================================
- Coverage 98.97% 98.96% -0.01%
==========================================
Files 87 88 +1
Lines 16733 16822 +89
==========================================
+ Hits 16561 16648 +87
- Misses 172 174 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
No obvious timing issues in HEAD=delete_by_ref Generated via commit 4888272 Download link for the artifact containing the test results: ↓ atime-results.zip
|
|
What if columns are not marked as resizable? AFAIU delete rows will have to create a resizable copy in order to remove it. Right? |
| // Parallel prefix sum (exclusive scan) | ||
| // Two-pass algorithm: first count per thread, then scan, then local prefix sum | ||
| static void computePrefixSum(const int *keep, int *dest, R_xlen_t n, int nthreads) { | ||
| if (nthreads == 1 || n < 10000) { |
There was a problem hiding this comment.
It looks like a good place to use throttle threshold rather than hardcoded 10000.
Threshold is set to 1024, so maybe just 10*threshold instead.
2 participants
Towards #635
Currently only supports deletion of
i, but could also be integrated intodogroups.Do we need/want a functional form like
delete(x, irows). Depending on what we allow forirowsthis would need a rewrite/duplicate of the internals of[ievaluation.