set automatically allocates new column slots if needed #7538
+17
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ben-schwen
requested review from
HughParsonage and
MichaelChirico
as code owners
|
No obvious timing issues in HEAD=set_automate_overalloc Generated via commit 76675c3 Download link for the artifact containing the test results: ↓ atime-results.zip
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7538 +/- ##
=======================================
Coverage 98.97% 98.97%
=======================================
Files 87 87
Lines 16733 16733
=======================================
Hits 16561 16561
Misses 172 172 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| test(2356.2, options=c(datatable.alloccol=1L), set(DT, j="c", value=3), data.table(a=1, b=2, c=3)) | ||
| # ensure := and set are consistent if they need to overallocate | ||
| DT = data.table(); DT2 = data.table() | ||
| test(2356.3, options=c(datatable.alloccol=1L), {for (i in seq(10L)) set(DT, j = paste0("V",i), value = i)}, {for (i in seq(10)) DT2[, sprintf("V%d",i) := i]}) |
Member
There was a problem hiding this comment.
I think we need ; DT and ; DT2 here, a for loop returns NULL so now the test just checks the code runs:
x = for (i in 1:10) i
dput(x)
# NULL
| { | ||
| # If removing columns from a table that's not selfrefok, need to call setalloccol first, #7488 | ||
| if ((is.null(value) || (is.list(value) && any(vapply_1b(value, is.null)))) && selfrefok(x, verbose=FALSE) < 1L) { | ||
| if (((is.null(value) || (is.list(value) && any(vapply_1b(value, is.null)))) && selfrefok(x, verbose=FALSE) < 1L) || |
Member
There was a problem hiding this comment.
too many parentheses :)
I propose this helper:
.set_needs_alloccol = function(x, value) {
if (truelength(x) <= length(x)) return(TRUE)
if (selfrefok(x, verbose=FALSE) >= 1L) return(FALSE)
if (is.null(value)) return(TRUE)
if (!is.list(value)) return(FALSE)
any(vapply_1b(value, is.null))
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1831
Closes #4100
Supersedes #5269
Originally posted by @MichaelChirico in #5269 (comment)
Basically yes, but we have to carry this ball anyway because of #7500