upgrade meta - #2
Merged
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
… declared dependencies - os_dependencies (libldap2-dev libsasl2-dev) so python-ldap can build on CI - use_test_matrix=false: with use_mxdev=true the per-Plone-version matrix was cosmetic (every env resolved the same constraints-mxdev.txt), so it never actually tested different Plone versions; revert to the historical single test/coverage env against Plone 6.1-dev - drop the circular job: plone/meta's circular.yml has no os_dependencies hook, so it can never install python-ldap's build deps - declare all directly-imported dependencies in setup.py and drop unused ones (collective.regenv, yafowil.plone, yafowil.bootstrap, plone.restapi)
profiles.zcml was never included from configure.zcml, so "redturtle.pasldap:default" was never a registered GenericSetup profile: the addon isn't installable through it and never was. Drop the dead profile scaffolding (profiles.zcml, profiles/, setuphandlers/, upgrades/) and the installation tests that assumed it worked, which were the only tests in the repository and the reason tests failed once CI actually started running them. With no tests left, treat pytest's "no tests collected" exit code as success so coverage/test CI jobs don't fail for that reason.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.