Repository navigation
feat(side-menu): animate nested sidebar expand/collapse - #2872
Draft
illionillion wants to merge 1 commit into
Draft
illionillion wants to merge 1 commit into
illionillion wants to merge 1 commit into
Conversation
Keep the theme height transition for nested groups, clamp the empty style frame that flashes the panel open, honor prefers-reduced-motion, and mark fully collapsed nested panels aria-hidden. Co-authored-by: Yuto Ichinose <illionillion@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why/How?
Nested groups in the v3 sidebar already animate their height through
@redocly/theme. This brings the rest of the pre-v3 accordion behavior onto currentmain:prefers-reduced-motionis set.aria-hiddenonce it is fully collapsed. The root list keeps the theme's native list semantics.Navigation, scroll sync, and keyboard behavior stay as they are.
Reference
Follow-up to #2779. That pull request targeted the pre-v3 sidebar and was closed with a request to rebase onto
main. This is a new draft fromcursor/sidebar-accordion-animation-c9c2on currentmain.Tests
aria-hidden, the reduced-motion rules, andSideMenuwiring.npm run lint,npm run ts:check, andnpm run unitpass.e2e/playwright/tests/menu.spec.ts(source project) passes.Check yourself