fix(respect): referenced workflow execution flow inconsistency#2966
Open
DmitryAnansky wants to merge 1 commit into
Open
fix(respect): referenced workflow execution flow inconsistency#2966DmitryAnansky wants to merge 1 commit into
DmitryAnansky wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: cb2139a The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
Contributor
Performance Benchmark (Lower is Faster)
|
Contributor
|
📦 A new experimental 🧪 version v0.0.0-snapshot.1784905704 of Redocly CLI has been published for testing. Install with NPM: npm install @redocly/cli@0.0.0-snapshot.1784905704 |
DmitryAnansky
marked this pull request as ready for review
July 24, 2026 15:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why/How?
Fixed
respectto stop parent workflow execution when a step that references another workflow fails. Previously, the next steps of the parent workflow were still executed after the referenced workflow failed.Reference
Closes: #2963
Testing
Screenshots (optional)
Check yourself
Security
Note
Medium Risk
Changes core workflow control flow for nested workflows; behavior shifts for specs that relied on continuing after a failed child, though that was the reported bug.
Overview
Respect now treats a referenced child workflow like a failed API step: when the nested run has failing steps,
runSteprunsonFailureactions and canshouldEndthe parent instead of always continuing.After
runWorkflowreturns,calculateTotalsdetects child failure. On failure, failure handlers run (includinggoto); if none apply, execution ends withshouldEnd: true.onSuccessruns only when the child did not fail.Unit coverage asserts the parent stops when the child has failed checks; workflow-step tests mock successful child runs. E2E max-steps adds
onFailureon the nested-workflow step so failure recovery matches the new flow.Reviewed by Cursor Bugbot for commit cb2139a. Bugbot is set up for automated code reviews on this repo. Configure here.