About Us: drive contributor list from backend directory endpoint - #172
Open
Trosper3 wants to merge 1 commit into
Open
About Us: drive contributor list from backend directory endpoint#172Trosper3 wants to merge 1 commit into
Trosper3 wants to merge 1 commit into
Conversation
The contributor list and GitHub links were hardcoded in the frontend,
requiring a code change for every new contributor. The backend already
exposes Navigation/ContributorProfile/directory and .../{name} (added
alongside PR #63, which went stale after the page's dark-theme redesign
in #77 made a literal merge impossible without reverting that redesign).
Fetches the directory through the existing /api/redux proxy on mount and
opens a profile dialog with bio/education/contributions on click, styled
to match the current page. Also fixes a pre-existing duplicate slotProps
prop on the contributor Tooltip that ESLint was already flagging.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015tmxHR2MpofFu5zLcHEgZ5
Redux Build System — CI Report
Overall: ❌ 2 passed · 3 failed · 3 skipped ❌ audit — 1 high
❌ format-check — 56 format · 31 import order
❌ lint — 24 errors, 41 warnings
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the hardcoded contributor list/avatar map on the About Us page with a live fetch from the backend, and adds a click-to-view profile dialog (bio, education, major, contribution breakdown).
Supersedes #63, which had the same goal but has been unmergeable since #77 rebuilt the page with the current dark theme in April — a literal merge would have reverted that redesign. This reimplements the same underlying idea against the current page instead.
Why #63 stalled
process.env.NEXT_PUBLIC_REDUX_BASE_URL, which was never set — this app fetches through the same-origin/api/redux/proxy (pages/api/redux/[...path].js) backed by a server-onlyREDUX_BASE_URLenv var. That's almost certainly why the contributor list didn't populate when @Trosper3 tested it in May.Navigation/ContributorProfile/directoryand.../{name}) do exist and work — added inReduxISU/Reduxalongside About Us: replace hardcoded contributor list with live API fetch + clickable profile modal #63 and extended in April.What changed
components/redux/index.js: addedrequestContributorDirectoryandrequestContributorProfile, matching the existingrequestAllProblems-style helpers (cached, hitNavigation/ContributorProfile/...through the proxy).pages/aboutus/index.js: contributor names and GitHub avatar/links now come from the directory fetch instead of a hardcoded array/object. Clicking a name opens a dialog (styled to match the current dark theme) with the contributor's bio/education/major/contributions, lazy-fetched on click. Falls back to a plain message if the backend is unreachable.slotPropsprop on the contributorTooltipthat ESLint was already flagging onReduxAPI_GUI(unrelated to this feature, but touched while in the file).Testing done
next buildandeslint .both pass.🤖 Generated with Claude Code