feat: algorithm attributions#345
Open
tristan-f-r wants to merge 7 commits intoReed-CompBio:mainfrom
Open
Conversation
tristan-f-r
added
the
awaiting-author
Documentation build overview
4 files changed± genindex.html± contributing/index.html± fordevs/spras.config.html± fordevs/spras.html |
tristan-f-r
removed
the
awaiting-author
agitter
reviewed
Nov 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5.
I'm a little wary of using the
.bibfiles as artifacts (they are very easily reproducible, though, in a similar fashion to our other generate-inputs/parse-outputs tests) because it does feel redundant, but I did want to leave that in, in case this actually is very useful to look for DOI correctness in future algorithm implementations.This conflicts with #292, but since it's a small change, it doesn't really matter which matter it's merged - just mentioning it for a heads up.
More importantly, though, this does need to change depending on when #320 is merged, since this needs to have
attribution-{rev}attached to it.Note
I don't know what the best practices are for bibtex? If there's formatting suggestions, I'm very open to them 👍