Overview
Add specific elements of the unit tests added that must be checked before the PR can be merged.
Details
- If new environment variables where added to a script, ensure:
- They are set/unset in:
- All existing unit tests.
- New unit tests.
- Unset in the
spec_helper.sh file.
- Full test coverage exists for modified/added
constants.sh file(s).
- When unit test coverage has increased, GitHub workflows have been updated to ensure unit tests will fail when code coverage drops below the new level.
- Consider what else should be added.
Justification
These things are easy to forget but if not done, product quality will drop.
Artifact(s)
- Create a PR that updates the
default_pull_request_template.md file.
- GitHub issue(s) to cover any additional GitHub PR templates that it's realized may be needed.
Scope
Update the default_pull_request_template.md file.
Relationship(s)
This was found while working #3, should continue to be updated as #3 is worked, and picked up right after #3 is complete.
Found By (OPTIONAL)
#3
Blocked By (OPTIONAL)
#3
Blocking (OPTIONAL)
This is high priority, so it should block most everything else.
Overview
Add specific elements of the unit tests added that must be checked before the PR can be merged.
Details
spec_helper.shfile.constants.shfile(s).Justification
These things are easy to forget but if not done, product quality will drop.
Artifact(s)
default_pull_request_template.mdfile.Scope
Update the
default_pull_request_template.mdfile.Open a PR for This Issue
Relationship(s)
This was found while working #3, should continue to be updated as #3 is worked, and picked up right after #3 is complete.
Found By (OPTIONAL)
#3
Blocked By (OPTIONAL)
#3
Blocking (OPTIONAL)
This is high priority, so it should block most everything else.