Skip to content

default_pull_request_template.md - Add Unit Testing Checks to GitHub PR Template #23

Description

@ReedClanton

Overview

Add specific elements of the unit tests added that must be checked before the PR can be merged.

Details

  • If new environment variables where added to a script, ensure:
    • They are set/unset in:
      • All existing unit tests.
      • New unit tests.
    • Unset in the spec_helper.sh file.
  • Full test coverage exists for modified/addedconstants.sh file(s).
  • When unit test coverage has increased, GitHub workflows have been updated to ensure unit tests will fail when code coverage drops below the new level.
  • Consider what else should be added.

Justification

These things are easy to forget but if not done, product quality will drop.

Artifact(s)

  • Create a PR that updates the default_pull_request_template.md file.
  • GitHub issue(s) to cover any additional GitHub PR templates that it's realized may be needed.

Scope

Update the default_pull_request_template.md file.

Open a PR for This Issue

Relationship(s)

This was found while working #3, should continue to be updated as #3 is worked, and picked up right after #3 is complete.

Found By (OPTIONAL)

#3

Blocked By (OPTIONAL)

#3

Blocking (OPTIONAL)

This is high priority, so it should block most everything else.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    documentationImprovements or additions to documentationenhancementNew feature or request

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions