Add option for ExportCSVConfig to target txn outputs#262
Draft
davidwzhao wants to merge 5 commits into
Draft
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
builtin.tuple is registered as variadic (arity -1), so make_builtin
gives it an empty param list and the generic type-variable matching
can't resolve the return type T. Add a special case that infers
TupleType directly from the argument types, matching what _infer_type
already does in the parser.
Without this, IfElse nodes wrapping tuple constructs were typed as
interface{} in Go, causing a compile error when the function's declared
return type is []interface{}.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…xportCSVConfig ExportCSVColumns had no custom == so structural comparison fell back to identity, breaking ExportCSVSource comparisons. Add equality for ExportCSVColumns first, then ExportCSVSource, then wire csv_source, csv_config, and the new transaction_output_name field into ExportCSVConfig ==, hash, and isequal. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
comnik
approved these changes
Jun 23, 2026
comnik
reviewed
Jun 23, 2026
Comment on lines
+348
to
+350
| # builtin.tuple is variadic; infer TupleType from the argument types directly. | ||
| if isinstance(self.func, Builtin) and self.func.name == "tuple": | ||
| return TupleType(tuple(a.target_type() for a in self.args)) |
Contributor
Author
There was a problem hiding this comment.
The new grammar rule i think is the first use of tuples as return values in the grammar, and this exposed a bug in the parser generator. I'm not super sure on the details, but Claude found the problem and this was its fix. It was causing errors before, and works properly now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.