Hardening: remove 21 DB unwraps, schema versioning, --cache-dir canonicalize, WalkDir cap, concurrent build guard#2
Merged
Conversation
…cache-dir, cap WalkDir at 500K, add concurrent build guard P0: All 21 DB .unwrap() calls replaced with graceful match+eprintln fallback. P1: PRAGMA user_version tracked; open_existing_db rejects mismatched schemas. P2: --cache-dir now canonicalized via std::fs::canonicalize. P3: WalkDir capped at 500,000 files with secondary truncate. P5: AtomicBool build_in_progress prevents concurrent index builds on switch_repo. 54/54 unit tests, 17/17 integration tests passing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Five hardening changes making stria crash-safe against corrupt DBs, stale schemas, symlink traversal, and concurrent builds.
Changes
Verification