docs(ui): correct visual gate diagnostics (RIG-3822) - #1279
Open
rigel-mintaka wants to merge 1 commit into
Open
rigel-mintaka wants to merge 1 commit into
rigel-mintaka wants to merge 1 commit into
Conversation
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
|
Compass engineering docs preview: https://compass-ui-rig-3822-correct.compass-eng-docs.pages.dev Deployed from |
Record the measured visual-gate failure modes in assertion units. Unset pinned variables fail closed; explicit host font configuration reds 10 of 11 assertions, and an explicit host Chromium 153 override versus pinned 150 reds 2 of 11, including bridge.png at 4311 pixels and bridge-prs.png at 3957 pixels. Check both rendering overrides before stale baselines. Spec-impact: none. Refs RIG-3822 Co-authored-by: Matt Wilkinson <matt@rigel.build>
rigel-mintaka
force-pushed
the
compass-ui/rig-3822-correct-visual-diagnostics
branch
from
September 18, 2026 02:09
eeb1e6b to
d64fd65
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct the
visual-gatetask comment after measuring explicit host overrides against the pinned browser and font configuration on current main. Unsetting either pinned variable fails closed; an explicit host font configuration reds 10 of 11 assertions, and pointingPLAYWRIGHT_CHROMIUM_PATHat host Chromium 153 instead of pinned Chromium 150 reds 2 of 11, includingbridge.pngat 4311 pixels andbridge-prs.pngat 3957 pixels. Override checks remain first; stale-baseline checks remain secondary.Spec-impact: none. Refs RIG-3822
Co-authored-by: Matt Wilkinson matt@rigel.build